[libcxx-commits] [PATCH] D159454: [libc++][hardening][NFC] Fix the 17 release notes to remove mentions of hardening

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 5 13:59:01 PDT 2023


ldionne added inline comments.


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:82
 - P2286R8 - Formatting Ranges
 - P2508R1 - Exposing std::basic-format-string
 
----------------
We also discussed updating some TODO(LLVM18) blocks, I think those are missing from the patch.


================
Comment at: libcxx/docs/ReleaseNotes/17.rst:131
 
-- The "safe" mode is replaced by the hardened mode in this release. The ``LIBCXX_ENABLE_ASSERTIONS`` CMake variable is
-  deprecated and setting it will trigger an error; use ``LIBCXX_HARDENING_MODE`` instead. Similarly, the
----------------
Don't we need to advertise this in LLVM 18 now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159454/new/

https://reviews.llvm.org/D159454



More information about the libcxx-commits mailing list