[libcxx-commits] [PATCH] D158358: [libc++][C++20 modules] Enabling in C++20.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

LGTM with nits, thanks!



================
Comment at: libcxx/docs/UsingLibcxx.rst:531-532
+
+The maintainers of MSVC STL, libstdc++, and libc++ have agreed to make the
+C++23 modules ``std`` and ``std.compat`` available in C++20 as an extension.
+
----------------
We should only discuss *our* implementation here. I don't think this documentation is the right place to make claims about other implementations, even though we've all agreed on this. For example, if they changed their minds, this documentation would become erroneous.

You could say something more vague like "Like other major implementations, libc++ provides C++23 modules in C++20 as an extension". Let's just not be specific.


================
Comment at: libcxx/modules/std/vector.inc:33
   using std::formatter;
+#endif // _LIBCPP_STD_VER >= 23
 } // namespace std
----------------
IMO many of these `#endif // ` comments are not really helpful since they are very short blocks. I find it adds clutter to the code more than anything. Non-blocking, but I would consider removing the comments for short blocks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158358/new/

https://reviews.llvm.org/D158358