[libcxx-commits] [PATCH] D156609: [libc++][print] Adds ostream overloads.

Tue Sep 5 08:40:48 PDT 2023

ldionne added inline comments.

================
Comment at: libcxx/docs/ImplementationDefinedBehavior.rst:14
+
+a terminal capable of displaying Unicode
+----------------------------------------
----------------
Also I think this entry is not sufficiently clear right now. You should explain what implementation-defined behavior you're talking about. Maybe provide a link to the section of the std you're talking about?

================
Comment at: libcxx/include/__availability:177-178

+    // This controls the availability of the C++23 print library,
+    // which has a dependency on the builtin library to use the buffer
+    // types of std::cout, std::cerr, and std::clog.
----------------

================
Comment at: libcxx/include/__availability:180
+    // types of std::cout, std::cerr, and std::clog.
+#   define _LIBCPP_AVAILABILITY_PRINT
+
----------------
Missing `_LIBCPP_AVAILABILITY_HAS_NO_FOO`.

================
Comment at: libcxx/include/__availability:356

+#  define _LIBCPP_AVAILABILITY_PRINT __attribute__((unavailable))
+
----------------
Missing `HAS_NO_FOO`!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156609/new/

https://reviews.llvm.org/D156609