[libcxx-commits] [PATCH] D65667: [libcxx] Avoid destructor call for error_category singletons

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Sep 5 07:38:16 PDT 2023


ldionne updated this revision to Diff 555865.
ldionne added a comment.

Re-introduce the union trick which is needed to implement nodestroy semantics on compilers that don't support the nodestroy attribute.

While we're at it, drop the nodestroy attribute since the union trick is enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65667/new/

https://reviews.llvm.org/D65667

Files:
  libcxx/src/CMakeLists.txt
  libcxx/src/error_category.cpp
  libcxx/src/future.cpp
  libcxx/src/ios.cpp
  libcxx/src/system_error.cpp
  libcxx/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/generic_category.pass.cpp
  libcxx/test/std/diagnostics/syserr/syserr.errcat/syserr.errcat.objects/system_category.pass.cpp
  libcxx/test/std/input.output/iostreams.base/std.ios.manip/error.reporting/iostream_category.pass.cpp
  libcxx/test/std/thread/futures/futures.errors/future_category.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D65667.555865.patch
Type: text/x-patch
Size: 12407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230905/aa5957c2/attachment.bin>


More information about the libcxx-commits mailing list