[libcxx-commits] [PATCH] D149660: [libc++][AIX] Add OS version to target triple

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

This seems to be the libc++ run https://buildkite.com/llvm-project/libcxx-ci/builds/29326

I'm not sure why it also runs other CIs, but that might be due to recent experiments. Maybe rebasing will solve the issue.



================
Comment at: libcxx/utils/ci/run-buildbot:656
+
+    TARGET=$(${CXX} --version | grep 'Target:' | awk '{print $2}')
+    PARAMS="target_triple=${TARGET}"
----------------
Jake-Egan wrote:
> ldionne wrote:
> > Normally, the target triple is figured out automatically in the CMake code. I think it's `LLVM_DEFAULT_TARGET_TRIPLE`. Is there a reason why that triple isn't inferred properly? If it were, I think this would not be necessary.
> We considered adding the AIX version to the triple in the driver, but we don't have a good way to retrieve the AIX version in the driver right now. So, we prefer to do it in the test-suite to avoid any potential problems.
Can you add some comment to explain this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149660/new/

https://reviews.llvm.org/D149660