[libcxx-commits] [PATCH] D150747: [libc++][ranges] Add benchmarks for the `from_range` constructors of `vector` and `deque`.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 4 08:52:20 PDT 2023


Mordante accepted this revision.
Mordante added a comment.
This revision is now accepted and ready to land.

LGTM after adding a comment.



================
Comment at: libcxx/benchmarks/CMakeLists.txt:80
+if (MSVC)
+  add_compile_options(/std:c++latest)
+else()
----------------
Please add a bit of comment here, once MSVC has `cxx_std_23` support we should use that instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150747/new/

https://reviews.llvm.org/D150747



More information about the libcxx-commits mailing list