[libcxx-commits] [PATCH] D157193: [libc++][ranges] P2116R9: Implements `views::enumerate`

Hristo Hristov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Sep 4 00:19:48 PDT 2023


H-G-Hristov marked an inline comment as done.
H-G-Hristov added a comment.

Thank you for the comments!



================
Comment at: libcxx/include/__ranges/enumerate_view.h:64
+  _LIBCPP_HIDE_FROM_ABI constexpr enumerate_view()
+    requires default_initializable<_View>
+  = default;
----------------
Mordante wrote:
> Can you test whether this helps `clang-format` to do slightly better?
It doesn't make a difference. I don't like how `requires` is snapped to the brackets `()` but I'll add it for consistency with the rest of the code.
I don't think that `clang-format` did that bad. Where else will `= default` or `{}` go without making it even less readable?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157193/new/

https://reviews.llvm.org/D157193



More information about the libcxx-commits mailing list