[libcxx-commits] [PATCH] D156924: WIP: [libc++][ranges] Implement `ranges::stride_view`.

Fri Sep 1 17:12:15 PDT 2023

hawkinsw added a comment.

In D156924#4635672 <https://reviews.llvm.org/D156924#4635672>, @var-const wrote:

> @hawkinsw First of all, thanks a ton for working on this! LLVM is currently in the process of moving away from Phabricator to GitHub reviews -- see https://discourse.llvm.org/t/logistics-of-the-transition-to-github-prs-for-libc-libc-abi-libunwind/73130. Since the review for this patch hasn't really started yet, I think it might be easier to open a new review on GitHub. Would that work for you? If you have a strong preference to keep the patch on Phabricator for now, that's ok, I can start the review here.

You got it!! I want to make sure that I do what the community wants! I will move it there and then comment back here and let you know where it lands!

> Btw, can you give a very brief outline on the current status of the patch? I notice it's still marked as WIP so I'm just curious which parts are still TODO. Would it make sense to start reviewing it now, or should I wait a bit? Let me know, and once again, thanks a lot for working on this!

Though I am a long-time C++ developer, I have only submitted minor optimizations to STL implementations to date. So, I _think_ that what is here is something that is roughly complete. What I am adding now are tests and it's taking a little longer than I had hoped. My day job as a teacher just ramped up again.

That is to say, I would love to start getting feedback on the patch and start refining it! I have had so much fun doing the implementation so far and learned a ton. I know that your review will help me learn even more!

Thank you for being so encouraging.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156924/new/

https://reviews.llvm.org/D156924