[libcxx-commits] [PATCH] D140612: [String] Apply clang formatting to all string unit tests

Petr Hosek via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Sep 1 15:44:09 PDT 2023


phosek added a comment.

Would it be possible to either revert this change or do a quick fix forward?



================
Comment at: libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg:2-3
+#These std::string functions require iostreams, which requires localization
+if
+"no-localization" in config.available_features : config.unsupported = True
----------------
This is not a valid Python syntax, we're seeing the following failure after this change on our builders:
```
llvm-lit: /b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestingConfig.py:151: fatal: unable to parse config file '/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg', traceback: Traceback (most recent call last):
  File "/b/s/w/ir/x/w/llvm-llvm-project/llvm/utils/lit/lit/TestingConfig.py", line 139, in load_from_path
    exec(compile(data, path, "exec"), cfg_globals, None)
  File "/b/s/w/ir/x/w/llvm-llvm-project/libcxx/test/std/strings/basic.string/string.nonmembers/string.io/lit.local.cfg", line 2
    if
     ^
SyntaxError: invalid syntax
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140612/new/

https://reviews.llvm.org/D140612



More information about the libcxx-commits mailing list