[libcxx-commits] [PATCH] D158922: [libc++] Implement LWG3545: std::pointer_traits should be SFINAE-friendly.

[Daniel Cheng via Phabricator via libcxx-commits]

zetafunction added a comment.

In D158922#4635027 <https://reviews.llvm.org/D158922#4635027>, @philnik wrote:

> In D158922#4634975 <https://reviews.llvm.org/D158922#4634975>, @zetafunction wrote:
>
>> Is there updated documentation for best practices for doing that? I was following https://libcxx.llvm.org/Contributing.html.
>
> We have just started the move, so I don't think there is any documentation yet. You should be able to just fork the llvm-project and then open a PR against the main repo.

Thanks, I've gone ahead and opened the PR at https://github.com/llvm/llvm-project/pull/65177? Since you commented, would you be willing to take a look at it? It hasn't been quite a week yet (per https://llvm.org/docs/Contributing.html#how-to-submit-a-patch) but I'm not sure what the best way to proceed here is either, since this is my first libc++ patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158922/new/

https://reviews.llvm.org/D158922