[libcxx-commits] [PATCH] D159171: [libc++][hardening] Remove hardening from release notes, undeprecate safe mode

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision as: ldionne.
ldionne added a comment.

LGTM with green CI, I think the remaining should be just nitpicks. I will let Mark give final approval.

In terms of landing this, this will need to be landed directly on `release/17.x` since there is no corresponding patch on `main`. Then we will need another patch on `main` that fixes up the release notes for LLVM 18 and also a few other things like the deprecation period for `LIBCXX_ENABLE_ASSERTIONS` (if my memory serves me right).



================
Comment at: libcxx/test/libcxx/assertions/modes/debug.pass.cpp:12
 
-// UNSUPPORTED: !libcpp-has-debug-mode
+// REQUIRES: libcpp-has-debug-mode && !libcpp-has-assertions
 // `check_assertion.h` is only available starting from C++11.
----------------
IMO we should just say `REQUIRES: libcpp-has-debug-mode` here since the `!libcpp-has-assertions` bit doesn't add anything.


================
Comment at: libcxx/test/libcxx/assertions/modes/debug_mode_disabled_in_tu.pass.cpp:11
 
-// UNSUPPORTED: libcpp-has-hardened-mode
+// REQUIRES: libcpp-has-debug-mode && !libcpp-has-assertions
 // ADDITIONAL_COMPILE_FLAGS: -Wno-macro-redefined -D_LIBCPP_ENABLE_DEBUG_MODE=0
----------------
Same here.


================
Comment at: libcxx/utils/ci/run-buildbot:498
 ;;
+apple-system-backdeployment-assertions--*)
+    clean
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159171/new/

https://reviews.llvm.org/D159171