[libcxx-commits] [PATCH] D140550: [String] Refactor unit tests to allow easy addition of new allocators

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/T_size_size.pass.cpp:72
       S s2(sv, static_cast<Size>(pos), static_cast<Size>(n), a);
       assert(false);
     } catch (std::out_of_range&) {
----------------
TODO: check this refactoring.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/copy_alloc.pass.cpp:80
 template <class S>
 TEST_CONSTEXPR_CXX20 void test(S s1, const typename S::allocator_type& a) {
   S s2(s1, a);
----------------
TODO: check this one.


================
Comment at: libcxx/test/std/strings/basic.string/string.cons/iter_alloc.pass.cpp:90
+TEST_CONSTEXPR_CXX20 bool test() {
+  test<test_allocator<char> >(test_allocator<char>(2));
+#if TEST_STD_VER >= 11
----------------



================
Comment at: libcxx/test/std/strings/basic.string/string.cons/move.pass.cpp:25
   S s1 = s0;
   S s2 = std::move(s0);
   LIBCPP_ASSERT(s2.__invariants());
----------------
TODO: check this one and everything below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140550/new/

https://reviews.llvm.org/D140550