[libcxx-commits] [libcxx] [libc++] Encode additional ODR-affecting properties in the ABI tag (PR #69669)

[Anton Rydahl via libcxx-commits]

AntonRydahl wrote:

Hi @ldionne 

This change breaks OpenMP offloading on my machine. I traced it back to this commit with git bisect. If I compile simple tests programs with OpenMP offloading enabled, I get errors like
```
"PluginInterface" error: Failure to load binary image 0x555555892c30 on device 0: Error in hsa_executable_get_symbol_by_name(__omp_offloading_16_cff8cf6__ZNSt3__122__omp_transform_reduceB8se180000IPdS1_ldvZ4mainE3$_0EET2_T_T0_T1_S3_NS_4plusIT3_EET4__l87.kd): HSA_STATUS_ERROR_INVALID_SYMBOL_NAME: There is no symbol with the given name.
Libomptarget error: Unable to generate entries table for device id 0.
Libomptarget error: Failed to init globals on device 0
Libomptarget error: Consult https://openmp.llvm.org/design/Runtimes.html for debugging options.
Libomptarget error: Source location information not present. Compile with -g or -gline-tables-only.
Libomptarget fatal error 1: failure of target construct while offloading is mandatory
```
and I did not get any from the previous commit in the log.

I am not trying to ask you to revert this commit, but could you please help me understand what side effects this commit could have?

https://github.com/llvm/llvm-project/pull/69669