[libcxx-commits] [libcxx] [libc++] Remove a few transitive includes (PR #70553)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 31 06:42:02 PDT 2023


ldionne wrote:

> > Wait, this is changing the exposed transitive includes in C++03/11/14/17/20 though. We normally only do that when we really need to. Is there a reason why you are doing that in this PR? This is effectively a breaking change.
> 
> I've only added includes and the one I added was `<version>`. That was already included transitively, it just didn't show up because we're not listing the transitive closure. We should probably do that, since there is no reason not to and just leads to confusion.

We actually used to and we stopped doing that because we wanted the ability to generate a dependency graph from these CSV files (in particular to detect cycles). I'm not sure we actually use that though, and in practice I agree that not storing the transitive closure makes these CSV files extremely difficult to understand.

LGTM.

https://github.com/llvm/llvm-project/pull/70553


More information about the libcxx-commits mailing list