[libcxx-commits] [libcxx] varconst/fix flaky atomic wait (PR #70435)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 31 00:12:39 PDT 2023


================
@@ -46,7 +47,7 @@ int main(int, char**) {
   // Postconditions: get_id() != id() is true and ssource.stop_possible() is true
   // and *this represents the newly started thread.
   {
-    std::jthread jt{[] {}};
----------------
huixie90 wrote:

Technically this test is specifically testing this constructor. If certain platforms does not support this constructor or need to pass in thread attributes, then it is no longer calling this constructor any more.  One could argue that this no longer tests the constructor as stated in the tests. But I am fine with this. 

https://github.com/llvm/llvm-project/pull/70435


More information about the libcxx-commits mailing list