[libcxx-commits] [libcxx] [libcxx][test] std::array::iterator are not pointers by C++ standard (PR #70729)

via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 30 14:49:05 PDT 2023


================
@@ -60,6 +60,13 @@ static_assert(!HasMakeHeapR<UncheckedRange<const int*>>); // Doesn't satisfy `so
 
 template <std::size_t N, class T, class Iter>
 constexpr void verify_heap(const std::array<T, N>& heapified, Iter last, std::array<T, N> expected) {
+  assert(heapified == expected);
----------------
philnik777 wrote:

This looks wrong to me. We should keep the iterator and range overload tests equivalent. Same for a few cases below.

https://github.com/llvm/llvm-project/pull/70729


More information about the libcxx-commits mailing list