[libcxx-commits] [PATCH] D149660: [libc++][AIX] Add OS version to target triple

[David Tenty via Phabricator via libcxx-commits]

daltenty added inline comments.


================
Comment at: libcxx/test/configs/ibm-libc++-shared.cfg.in:7
 
+if 'aix' in config.target_triple:
+  import subprocess, re
----------------
daltenty wrote:
> Maybe you can make this a utility function inside `llvm/utils/lit/lit/util.py` to avoid repeating the code? 
> 
> (There are similarish util functions for macos for example)
I'm confused, why not move this whole complicated function? (You've only moved the target check)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149660/new/

https://reviews.llvm.org/D149660