[libcxx-commits] [libcxx] libcxx: remove redundant <cstdint> include from <string> (PR #70613)

Jade Lovelace via libcxx-commits libcxx-commits at lists.llvm.org
Sun Oct 29 17:49:06 PDT 2023


https://github.com/lf- created https://github.com/llvm/llvm-project/pull/70613

It looks like this has been there for so long that my git-blaming ran into the end of history when libc++ was imported from svn in 2010. This change will undoubtedly break some downstream code with broken includes, but libstdc++ does not do the same here, so such code was already broken on libstdc++; as such this change improves compatibility between the two implementations.

>From e26eceb234e7f92d1ff64e2ffb0797dcdc8ff9ac Mon Sep 17 00:00:00 2001
From: Jade Lovelace <software at lfcode.ca>
Date: Sun, 29 Oct 2023 17:35:11 -0700
Subject: [PATCH] libcxx: remove redundant <cstdint> include from <string>

It looks like this has been there for so long that my git-blaming ran
into the end of history when libc++ was imported from svn in 2010. This
change will undoubtedly break some downstream code with broken includes,
but libstdc++ does not do the same here, so such code was already broken
on libstdc++.
---
 libcxx/include/string | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libcxx/include/string b/libcxx/include/string
index cf9f0c847eb43af..68f13414c7b6948 100644
--- a/libcxx/include/string
+++ b/libcxx/include/string
@@ -614,7 +614,6 @@ basic_string<char32_t> operator""s( const char32_t *str, size_t len );
 #include <__utility/swap.h>
 #include <__utility/unreachable.h>
 #include <climits>
-#include <cstdint>
 #include <cstdio>  // EOF
 #include <cstring>
 #include <limits>



More information about the libcxx-commits mailing list