[libcxx-commits] [libcxx] [libcxx][test] Amend XFAIL for failing tests (PR #70422)

[Petr Hosek via libcxx-commits]

https://github.com/petrhosek updated https://github.com/llvm/llvm-project/pull/70422

>From 202fb4771bdaafe9d8f72954caa969c259400bde Mon Sep 17 00:00:00 2001
From: Petr Hosek <phosek at google.com>
Date: Fri, 27 Oct 2023 07:15:03 +0000
Subject: [PATCH] [libcxx] Amend XFAIL for failing tests on Windows

Some tests starting passing/failing after #69431 because Clang no longer
enables -fdelayed-template-parsing by default on Windows with C++20.
---
 .../atomics/diagnose_invalid_memory_order.verify.cpp       | 7 ++++---
 libcxx/test/libcxx/fuzzing/random.pass.cpp                 | 4 ++++
 libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp        | 4 ++++
 libcxx/test/std/numerics/c.math/cmath.pass.cpp             | 4 ++++
 4 files changed, 16 insertions(+), 3 deletions(-)

diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
index a6c1160c7022f07..defd43cf267a9ff 100644
--- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -6,9 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
-// This test fails because diagnose_if doesn't emit all of the diagnostics
-// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
-// XFAIL: msvc
+// This test fails with Clang <18 because diagnose_if doesn't emit all of the
+// diagnostics when -fdelayed-template-parsing is enabled, like it is in MSVC
+// mode.
+// XFAIL: msvc && (clang-16 || clang-17)
 
 // REQUIRES: diagnose-if-support
 
diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp
index 79ab7ac41151c97..69b496fa3a4e66f 100644
--- a/libcxx/test/libcxx/fuzzing/random.pass.cpp
+++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp
@@ -6,6 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails because Clang no longer enables -fdelayed-template-parsing
+// by default on Windows with C++20 (#69431).
+// XFAIL: msvc && clang-18
+
 // UNSUPPORTED: c++03, c++11
 
 #include <cassert>
diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
index 87767a2ee4311cb..7a6c71ae68f797c 100644
--- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
@@ -6,6 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails because Clang no longer enables -fdelayed-template-parsing
+// by default on Windows with C++20 (#69431).
+// XFAIL: msvc && clang-18
+
 // <math.h>
 
 #include <math.h>
diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
index 11a3de748cb7a69..a6a9dad639cdff9 100644
--- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
@@ -6,6 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails because Clang no longer enables -fdelayed-template-parsing
+// by default on Windows with C++20 (#69431).
+// XFAIL: msvc && clang-18
+
 // <cmath>
 
 #include <cmath>