[libcxx-commits] [libcxx] [libcxx][test] Amend XFAIL for failing tests (PR #70422)

[Petr Hosek via libcxx-commits]

https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/70422

Some tests starting passing/failing after #69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20 modules.

>From 8ad046187da5768cf6a06edaad43076f808e7687 Mon Sep 17 00:00:00 2001
From: Petr Hosek <phosek at google.com>
Date: Fri, 27 Oct 2023 07:15:03 +0000
Subject: [PATCH] [libcxx][test] Amend XFAIL for failing tests

Some tests starting passing/failing after #69431 because Clang no longer
enables -fdelayed-template-parsing by default on Windows with C++20
modules.
---
 .../libcxx/atomics/diagnose_invalid_memory_order.verify.cpp  | 2 +-
 libcxx/test/libcxx/fuzzing/random.pass.cpp                   | 5 +++++
 libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp          | 5 +++++
 libcxx/test/std/numerics/c.math/cmath.pass.cpp               | 4 ++++
 4 files changed, 15 insertions(+), 1 deletion(-)

diff --git a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
index a6c1160c7022f07..45c3f81fffd3d44 100644
--- a/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
+++ b/libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp
@@ -8,7 +8,7 @@
 
 // This test fails because diagnose_if doesn't emit all of the diagnostics
 // when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
-// XFAIL: msvc
+// XFAIL: msvc && (clang-16 || clang-17)
 
 // REQUIRES: diagnose-if-support
 
diff --git a/libcxx/test/libcxx/fuzzing/random.pass.cpp b/libcxx/test/libcxx/fuzzing/random.pass.cpp
index 79ab7ac41151c97..21b7c9348c07821 100644
--- a/libcxx/test/libcxx/fuzzing/random.pass.cpp
+++ b/libcxx/test/libcxx/fuzzing/random.pass.cpp
@@ -6,6 +6,11 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules
+// (#69431).
+// XFAIL: msvc && clang-18
+
 // UNSUPPORTED: c++03, c++11
 
 #include <cassert>
diff --git a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
index 87767a2ee4311cb..eaa8b1ac44c7471 100644
--- a/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
+++ b/libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp
@@ -6,6 +6,11 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules (#69431).
+
+// XFAIL: msvc && clang-18
+
 // <math.h>
 
 #include <math.h>
diff --git a/libcxx/test/std/numerics/c.math/cmath.pass.cpp b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
index 11a3de748cb7a69..ab7c759dcb438b2 100644
--- a/libcxx/test/std/numerics/c.math/cmath.pass.cpp
+++ b/libcxx/test/std/numerics/c.math/cmath.pass.cpp
@@ -6,6 +6,10 @@
 //
 //===----------------------------------------------------------------------===//
 
+// This test fails with because Clang no longer enables
+// -fdelayed-template-parsing by default on Windows with C++20 modules (#69431).
+// XFAIL: msvc && clang-18
+
 // <cmath>
 
 #include <cmath>