[libcxx-commits] [PATCH] D155521: Run picolibc tests with qemu

Wed Oct 25 14:02:23 PDT 2023

arichardson added inline comments.

================
Comment at: libcxx/utils/run-qemu.sh:19
+
+"${QEMU_EXECUTABLE}" \
+    -chardev stdio,mux=on,id=stdio0 \
----------------
arichardson wrote:
> michaelplatings wrote:
> > arichardson wrote:
> > > arichardson wrote:
> > > > I wonder if this should instead be a full executor such as qemu_system.py (similar to ssh.py) that accepts all the same flags and just requires something like `--qemu=qemu-system-arm --cpu=.. --machine=...`
> > > Done as part of https://github.com/llvm/llvm-project/pull/68643, let me know if that works for you?
> > I'm not sure whether the Python script is an improvement but I'd go with whatever gets these patches landed sooner. I think that to be used in place of `run.py` the Python script would need to support the full interface of `run.py` i.e. `--codesign_identity` et al.
> That's a good point, so far I've tested it with libunwind, will try libc++ as well.
I was able to use the new script for libc++ since the other arguments do not appear to be used.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155521/new/

https://reviews.llvm.org/D155521