[libcxx-commits] [PATCH] D149660: [libc++][AIX] Add OS version to target triple

David Tenty via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 24 08:26:42 PDT 2023


daltenty accepted this revision.
daltenty added inline comments.


================
Comment at: libcxx/test/configs/ibm-libc++-shared.cfg.in:7
 
+if 'aix' in config.target_triple:
+  import subprocess, re
----------------
Maybe you can make this a utility function inside `llvm/utils/lit/lit/util.py` to avoid repeating the code? 

(There are similarish util functions for macos for example)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149660/new/

https://reviews.llvm.org/D149660



More information about the libcxx-commits mailing list