[libcxx-commits] [libcxx] [libc++] Remove the Buildkite job that builds documentation (PR #69992)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Mon Oct 23 17:53:37 PDT 2023


https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/69992

Since #69828, we have a Github Action that builds the documentation for libc++, so we don't need to do it as part of our Buildkite pipeline anymore.

>From 04fef9989f8abfc10a7b473daa4e19edd3a3e36b Mon Sep 17 00:00:00 2001
From: Louis Dionne <ldionne.2 at gmail.com>
Date: Mon, 23 Oct 2023 17:51:45 -0700
Subject: [PATCH] [libc++] Remove the Buildkite job that builds documentation

Since #69828, we have a Github Action that builds the documentation
for libc++, so we don't need to do it as part of our Buildkite pipeline
anymore.
---
 libcxx/utils/ci/Dockerfile             |  4 ++--
 libcxx/utils/ci/buildkite-pipeline.yml | 21 ---------------------
 libcxx/utils/ci/run-buildbot           |  7 -------
 3 files changed, 2 insertions(+), 30 deletions(-)

diff --git a/libcxx/utils/ci/Dockerfile b/libcxx/utils/ci/Dockerfile
index 35f03b90c03d99d..962de84e852ce59 100644
--- a/libcxx/utils/ci/Dockerfile
+++ b/libcxx/utils/ci/Dockerfile
@@ -38,9 +38,9 @@ ENV DEBIAN_FRONTEND=noninteractive
 RUN apt-get update && apt-get install -y bash curl
 
 # Install various tools used by the build or the test suite
-#RUN apt-get update && apt-get install -y ninja-build python3 python3-sphinx python3-distutils python3-psutil git gdb ccache
+#RUN apt-get update && apt-get install -y ninja-build python3 python3-distutils python3-psutil git gdb ccache
 # TODO add ninja-build once 1.11 is available in Ubuntu, also remove the manual installation.
-RUN apt-get update && apt-get install -y python3 python3-sphinx python3-distutils python3-psutil git gdb ccache
+RUN apt-get update && apt-get install -y python3 python3-distutils python3-psutil git gdb ccache
 RUN apt-get update && apt-get install -y wget && \
   wget -qO /usr/local/bin/ninja.gz https://github.com/ninja-build/ninja/releases/latest/download/ninja-linux.zip && \
   gunzip /usr/local/bin/ninja.gz && \
diff --git a/libcxx/utils/ci/buildkite-pipeline.yml b/libcxx/utils/ci/buildkite-pipeline.yml
index f195331eac2474d..5a5bc39c5797bdd 100644
--- a/libcxx/utils/ci/buildkite-pipeline.yml
+++ b/libcxx/utils/ci/buildkite-pipeline.yml
@@ -29,32 +29,11 @@ env:
     LLVM_HEAD_VERSION: "18"   # Used compiler, update POST-BRANCH.
     GCC_STABLE_VERSION: "13"
 steps:
-  #
-  # Light pre-commit tests for things like forgetting to update generated files.
-  #
-  - label: "Documentation"
-    command: "libcxx/utils/ci/run-buildbot documentation"
-    artifact_paths:
-      - "**/test-results.xml"
-    env:
-        CC: "clang-${LLVM_HEAD_VERSION}"
-        CXX: "clang++-${LLVM_HEAD_VERSION}"
-    agents:
-      queue: "libcxx-builders"
-      os: "linux"
-    retry:
-      automatic:
-        - exit_status: -1  # Agent was lost
-          limit: 2
-    timeout_in_minutes: 120
-
   #
   # General testing with the default configuration, under all the supported
   # Standard modes, with Clang and GCC. This catches most issues upfront.
   # The goal of this step is to catch most issues while being very fast.
   #
-  - wait
-
   - label: "GCC ${GCC_STABLE_VERSION} / C++latest"
     command: "libcxx/utils/ci/run-buildbot generic-gcc"
     artifact_paths:
diff --git a/libcxx/utils/ci/run-buildbot b/libcxx/utils/ci/run-buildbot
index be96bb65ef94122..89910738f52d040 100755
--- a/libcxx/utils/ci/run-buildbot
+++ b/libcxx/utils/ci/run-buildbot
@@ -587,13 +587,6 @@ benchmarks)
     generate-cmake
     check-cxx-benchmarks
 ;;
-documentation)
-    clean
-    generate-cmake -DLLVM_ENABLE_SPHINX=ON
-
-    echo "+++ Generating documentation"
-    ${NINJA} -vC "${BUILD_DIR}" docs-libcxx-html
-;;
 aarch64)
     clean
     generate-cmake -C "${MONOREPO_ROOT}/libcxx/cmake/caches/AArch64.cmake"



More information about the libcxx-commits mailing list