[libcxx-commits] [libcxxabi] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Oct 20 15:23:04 PDT 2023


================
@@ -45,10 +45,10 @@ config.substitutions.append(('%{flags}',
     '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else ''
 ))
 config.substitutions.append(('%{compile_flags}',
-    '-nostdinc++ -I %{include} -I %{libcxx}/test/support'
+    '@CMAKE_CXX_FLAGS_INIT@ -nostdinc++ -I %{include} -I %{libcxx}/test/support'
----------------
EricWF wrote:

I don't think this makes sense. The flags you use to build the library may not be the flags our users use when using it.


I think the test suite should handle its flags manually, and we should find another route to get you what you want here.



https://github.com/llvm/llvm-project/pull/67201


More information about the libcxx-commits mailing list