[libcxx-commits] [libcxx] [libc++][Android] Enable Android testing in BuildKite CI (PR #69275)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Oct 20 10:57:54 PDT 2023
ldionne wrote:
> woo-hoo! I think this is the only change we need to land!
>
> I will ask one thing though. I'm a bit concerned that we don't yet have the capacity to handle this change as a pre-commit check. Could we initially turn it on at some other schedule, something like post-commit, hourly, or rolling head, so we can gain some confidence. Then we'll upgrade it after a week or so?
IMO we should do like we do for all the other jobs and run it as pre-commit. We should tackle that issue separately like we've been discussing, but we shouldn't try to mash up improving our CI latency with this new platform support effort. Concretely, the libc++ policy is to require pre-commit CI for all the supported platforms, so we should just stick to it until we have the technical means to do several layers of testing and we have updated our policy to account for that.
https://github.com/llvm/llvm-project/pull/69275
More information about the libcxx-commits
mailing list