[libcxx-commits] [libcxx] [libc++][Android] Add NDK ABI lists for i686 and x86_64 (PR #69272)

Ryan Prichard via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 19 16:09:33 PDT 2023


rprichard wrote:

> If it's not already clear elsewhere, could you document how to regenerate these?

I think `run-buildbot` generates the ABI list files when it runs and uploads them as BuildKite artifacts (see the line in the `android-ndk-*` section that invokes `check-abi-list`. The CI fails if the generated list doesn't match what's checked in.

I mostly included these files because the other libc++ targets also had them. I don't actually know if we need them or not. I'd be happy to leave them out (and modify run-buildbot to stop checking them for Android).

Aside: The name of the two files is a bit off, because it doesn't include the term "ndk", and I think we probably want to add a libc++ test for the Android platform build of libc++, which is a bit different -- e.g. it uses `std::__1` instead of `std::__ndk1`, targets a different API level, and separates out the libc++abi demangler into a static archive that usually isn't needed.


https://github.com/llvm/llvm-project/pull/69272


More information about the libcxx-commits mailing list