[libcxx-commits] [libcxx] [libcxx][test] Fix empty.gen selftest on windows (PR #69403)

Joel E. Denny via libcxx-commits libcxx-commits at lists.llvm.org
Thu Oct 19 11:22:37 PDT 2023


================
@@ -8,4 +8,4 @@
 
 // Make sure the test passes if it succeeds to run
 
-// RUN: true
+// RUN: :
----------------
jdenny-ornl wrote:

Lit's test suite has [tests where RUN lines containing true/false execute with lit's internal shell](https://github.com/llvm/llvm-project/blob/main/llvm/utils/lit/tests/Inputs/shtest-run-at-line/internal-shell/basic.txt) (not bash), and they [appear to succeed in windows bots](https://lab.llvm.org/buildbot/#/builders/216).  That suggests to me that true/false are available as external commands there.  Maybe @dyung can shed some light on that setup.

Is the goal of this patch to relax windows installation requirements, or am I just misunderstanding what's happening?

https://github.com/llvm/llvm-project/pull/69403


More information about the libcxx-commits mailing list