[libcxx-commits] [libcxx] [libcxx][test] Fix empty.gen selftest on windows (PR #69403)

via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 17 19:21:37 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Duo Wang (wdunicornpro)

<details>
<summary>Changes</summary>

Using `true` as a no-op unfortunately does not work on windows, which fails libcxx lit tests on windows. Using `cd .` is a good solution that should work across most platforms, but any suggestion is appreciated.

---
Full diff: https://github.com/llvm/llvm-project/pull/69403.diff


1 Files Affected:

- (modified) libcxx/test/libcxx/selftest/gen.cpp/empty.gen.cpp (+1-1) 


``````````diff
diff --git a/libcxx/test/libcxx/selftest/gen.cpp/empty.gen.cpp b/libcxx/test/libcxx/selftest/gen.cpp/empty.gen.cpp
index 1915bede471f5e4..21fa2adddfbc460 100644
--- a/libcxx/test/libcxx/selftest/gen.cpp/empty.gen.cpp
+++ b/libcxx/test/libcxx/selftest/gen.cpp/empty.gen.cpp
@@ -8,4 +8,4 @@
 
 // Make sure we can generate no tests at all
 
-// RUN: true
+// RUN: cd .

``````````

</details>


https://github.com/llvm/llvm-project/pull/69403


More information about the libcxx-commits mailing list