[libcxx-commits] [libcxx] [libc++] Fix UB in <expected> related to "has value" flag (#68552) (PR #68733)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Tue Oct 17 10:37:51 PDT 2023


Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>,
Jan =?utf-8?q?Kokem=C3=BCller?= <jan.kokemueller at gmail.com>
Message-ID:
In-Reply-To: <llvm/llvm-project/pull/68733/libcxx at github.com>


================
@@ -43,6 +44,16 @@ constexpr bool test() {
     assert(!e.has_value());
   }
 
+  // See comments of the corresponding test in "expected.expected".
----------------
ldionne wrote:

Can you use a full path to the file where these comments live?

https://github.com/llvm/llvm-project/pull/68733


More information about the libcxx-commits mailing list