[libcxx-commits] [PATCH] D149660: [libc++][AIX] Add OS version to target triple

[David Tenty via Phabricator via libcxx-commits]

daltenty added inline comments.


================
Comment at: libcxx/utils/ci/run-buildbot:711
+    VERSION=$(oslevel -s | awk -F'-' '{printf "%.1f.%d.%d\n", $1/1000, $2, $3}')
+    if [ "$OBJECT_MODE" -eq 32 ]; then
+        PARAMS="target_triple=powerpc-ibm-aix${VERSION}"
----------------
Hmm, I wonder if this script is really the right place for this. If you don't go through this script to do the build, or the environment like this var isn't properly set when you run it, you won't get a correct test run result.

I think it would be better if this was implemented somewhere inside the lit config somehow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149660/new/

https://reviews.llvm.org/D149660