[libcxx-commits] [libcxx] [libcxx] patch for implementing ranges::find_last (PR #67270)

[via libcxx-commits]

philnik777 wrote:

> > > I'd prefer it if we implemented `find_last` and `find_last_if` independently, instead of deferring to an implementation function.
> > 
> > 
> > Why?
> 
> It simplifies the implementation so that we can directly call `x == y`, rather than having to go through `std::invoke`, which is currently opaque and bad for debug info.

It also means we'll have to duplicate optimizations, which significantly increases the complexity of the implementation. Improving the code gen of `std::invoke` seems like a really good idea regardless, so IMO that should be the way to go instead. I'd be happy to work on that with you (you already started working on that, right?).

https://github.com/llvm/llvm-project/pull/67270