[libcxx-commits] [PATCH] D154796: [libc++] Recategorize additional instantiations in the dylib as availability macros

Mon Oct 16 11:20:58 PDT 2023

philnik added a comment.

In D154796#4654067 <https://reviews.llvm.org/D154796#4654067>, @hnrklssn wrote:

> In D154796#4654047 <https://reviews.llvm.org/D154796#4654047>, @philnik wrote:
>
>> In D154796#4654012 <https://reviews.llvm.org/D154796#4654012>, @hnrklssn wrote:
>>
>>> This patch is currently our main suspect for this stage2 linker error <https://green.lab.llvm.org/green/job/clang-stage2-Rthinlto/7602/console>. @philnik Do you have any ideas off the top of your head for what might cause this?
>>
>> Thanks for the heads-up! Could you check whether e9c101a <https://reviews.llvm.org/rGe9c101a7533a829f48678589c7382d4c21c2eb1b> fixes it?
>
> I’ve had some issues building stage2 builds on my machine, so I’ve struggled reproducing it locally. If you’re certain the new include should be there regardless, I’d say the fastest way to learn whether it fixes this particular problem would be to commit it and wait for CI to build, tbh. Otherwise I’ll give it another go in the morning.

I've committed it already, since it's definitely missing. I wasn't sure whether the bot was building from trunk or not.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154796/new/

https://reviews.llvm.org/D154796