[libcxx-commits] [libcxx] Lower std::string's alignment requirement from 16 to 8. (PR #68807)

[Louis Dionne via libcxx-commits]

================
@@ -18,7 +18,13 @@
 #include "test_macros.h"
 
 // alignment of the string heap buffer is hardcoded to 16
-static const std::size_t alignment = 16;
+
+static const std::size_t alignment =
+#ifdef _LIBCPP_ABI_STRING_8_BYTE_ALIGNMENT
----------------
ldionne wrote:

Can you prepare the patch to clean up the ABI flag and make it the default value before we merge this (kind of like a stacked review even though those aren't great in GH PRs)? I'd really like to make sure that we don't just check in this ABI flag without its removal if we all agree that we don't want the ABI flag in the end.

https://github.com/llvm/llvm-project/pull/68807