[libcxx-commits] [libcxx] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

[via libcxx-commits]

philnik777 wrote:

> @philnik777 These clang-tidy errors should really not be errors, do you have a preference for how to deal with those?

That depends on what we want to do with these kinds of issues in general. I think we should avoid making functions so complex. If we have a general consensus there, I think we should just suppress the warning with a todo that the function should be split up (or simplified some other way). If not, then I guess we can just disable the clang-tidy check. Having it non-fatal is somewhat useless IMO, just like having compiler warning non-fatal is useless.

https://github.com/llvm/llvm-project/pull/67023