[libcxx-commits] [libcxx] [libcxx] [docs] Remove mention of a MSVC/Debug mode caveat (PR #68791)

via libcxx-commits libcxx-commits at lists.llvm.org
Wed Oct 11 04:08:45 PDT 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Martin Storsjö (mstorsjo)

<details>
<summary>Changes</summary>

Since e346fd8a60d4969b29bdd1740a89b1ea43635331 and cd1b8be8de91bc1c43bac3eea7ebf3b5643b031c, the tests should run fine in Debug mode, with failed asserts not popping up blocking dialog boxes.

---
Full diff: https://github.com/llvm/llvm-project/pull/68791.diff


1 Files Affected:

- (modified) libcxx/docs/BuildingLibcxx.rst (-3) 


``````````diff
diff --git a/libcxx/docs/BuildingLibcxx.rst b/libcxx/docs/BuildingLibcxx.rst
index e919e1e6f32bfc3..ec4e381fe5b74c2 100644
--- a/libcxx/docs/BuildingLibcxx.rst
+++ b/libcxx/docs/BuildingLibcxx.rst
@@ -145,9 +145,6 @@ should add e.g. ``-DCMAKE_CXX_COMPILER_TARGET=x86_64-windows-msvc`` (replacing
 line above. This will instruct ``check-cxx`` to use the right target triple
 when invoking ``clang++``.
 
-Also note that if not building in Release mode, a failed assert in the tests
-pops up a blocking dialog box, making it hard to run a larger number of tests.
-
 CMake + ninja (MinGW)
 ---------------------
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/68791


More information about the libcxx-commits mailing list