[libcxx-commits] [PATCH] D140925: [CMake] Use Clang to infer the target triple

[Shoaib Meenai via Phabricator via libcxx-commits]

smeenai added inline comments.


================
Comment at: runtimes/CMakeLists.txt:167
 
+if(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR AND NOT APPLE)
+  set(CXX_TARGET_TRIPLE ${CMAKE_CXX_COMPILER} --target=${LLVM_RUNTIME_TRIPLE} -print-target-triple)
----------------
ldionne wrote:
> Is there any reason why you're carving out Apple here? Is it because `-print-target-triple` doesn't work properly on that platform (I think this rings a bell).
> 
> Anyway, this is non-blocking.
I think it's cos `LLVM_PER_TARGET_RUNTIME_DIR` is not supported for Apple platforms in general. I see a bunch of similar conditionals in other parts of compiler-rt.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140925/new/

https://reviews.llvm.org/D140925