[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard marked an inline comment as done.
rprichard added inline comments.


================
Comment at: libcxx/cmake/caches/AndroidNDK.cmake:13
+# older versions of Android).
+set(LIBCXX_ABI_VERSION 1)
+set(LIBCXX_ABI_NAMESPACE __ndk1 CACHE STRING "")
----------------
smeenai wrote:
> You aren't caching this, so it won't have any effect. It's also the default though, so you don't need to specify it explicitly.
Thanks for noticing this! I uploaded a fix.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147