[libcxx-commits] [libcxx] [libc++][hardening] Enable comparator checks for safe mode too (PR #66458)

[Konstantin Varlamov via libcxx-commits]

var-const wrote:

@rupprecht Sorry about the delay! We just published an [RFC for hardening](https://discourse.llvm.org/t/rfc-hardening-in-libc/73925) which is relevant to this discussion.

In our current model, these checks are only suitable for the debug mode -- IMO they are too expensive to be enabled in one of the production-usable modes in most cases. IIUC, you want these checks when running tests but find that the debug mode is too slow for your needs. I feel this might indicate a problem with the way we currently define the debug mode -- if it's too slow even for testing, then it would simply be unusable.

Can you share more details about the test timeouts? I'm particularly interested in how significant the timeout is (is the test running time just a little above the threshold, or is it several times longer than the threshold, etc.) and which checks are the most responsible for the timeout.

https://github.com/llvm/llvm-project/pull/66458