[libcxx-commits] [libcxx] [libc++] Simplify how the global stream tests are written (PR #66842)

[Martin Storsjö via libcxx-commits]

mstorsjo wrote:

> > In most configs, we do have `bash` set up to be available when running tests on Windows, but I did run into one case in one setup where the tests previously were skipped but now execute and fail due to the missing `echo` executable.
> 
> Interesting. But aren't we using the Lit builtin `echo` command? I don't think we should ever be trying to call an `echo` executable on the platform?

That was what I thought as well, but I had to dive through a bit of lit to see what it does. It turns out that lit only uses the builtin `echo` if it's not part of a pipeline - probably due to potential blocking, if I understand the comments correctly: https://github.com/llvm/llvm-project/blob/llvmorg-18-init/llvm/utils/lit/lit/TestRunner.py#L742-L748

https://github.com/llvm/llvm-project/pull/66842