[libcxx-commits] [PATCH] D148432: [libc++] Simplify the tuple constructor overload set

Thu Oct 5 09:15:20 PDT 2023

ldionne added a comment.

[Github PR transition cleanup]

We've had numerous discussions on Discord about this since the discussion on this patch happened. We also asked the GCC folks what was their stance on GCC extensions in earlier language modes, and their reply basically matched what @aaron.ballman told us for Clang: extensions won't be removed unless they are broken in some significant way. At this point, I believe everyone's concerns have been addressed and I don't see what we could do to gain more consensus on this specific patch.

@Mordante Can you please let us know if you still have concerns with this patch? Otherwise, we would aim to land it by Friday October 13th (a bit more than a week away).

In D148432#4350856 <https://reviews.llvm.org/D148432#4350856>, @ldionne wrote:

> 1. Create a recurring monthly meeting for libc++ developers, similar to the regular meetings that happen for Clang. We can discuss general libc++ topics "in person" during those meetings and let everyone sync up with what's going on in the project.

Just to be clear, this is still on my TODO list, but I don't think it is reasonable to block this patch on setting that up, since any concerns with this patch can also be discussed right here on Phab or on Discord (like we've done).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148432/new/

https://reviews.llvm.org/D148432