[libcxx-commits] [PATCH] D154987: [lit] Implement PYTHON directive and config.prologue

Wed Oct 4 02:23:45 PDT 2023

awarzynski added a comment.

In D154987#4652527 <https://reviews.llvm.org/D154987#4652527>, @jdenny wrote:

> @awarzynski I recall you had some concerns and that we addressed some. What is your current opinion?

Sorry for delay, I tend to focus on GitHub these days.

I'm OK with this change.  Based on the feedback, this is clearly desirable by various folks. And great deal of effort has gone into preparing LIT for this PR, so I wouldn't want to block it. While I'm still concerned about extending LIT like this, there's an option for people _not to use_ the new directive.

As always with this sort of changes, I suggest "advertising" on Discourse to make sure that people are aware what's coming. Also, is any other sub-project beyond libcxx intending to use this?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154987/new/

https://reviews.llvm.org/D154987