[libcxx-commits] [libcxx] [libc++] Add std::fpclassify overloads for floating-point. (PR #67913)

[via libcxx-commits]

https://github.com/philnik777 requested changes to this pull request.

The implementation looks good, but this needs tests. Specifically,
- there should be a regression test to make sure an implicit conversion works now
- please make sure that we have test coverage for the `_LIBCPP_NODISCARD_EXT`s
- please make sure that we have test for the `noexcept`ness of the overloads.
You should be able to find tests for this under `libcxx/test/libcxx/{diagnostics,numerics/c.math}` if they exist.

https://github.com/llvm/llvm-project/pull/67913