[libcxx-commits] [libcxx] [libc++][test] Workaround for atomic tests linker errors on Linux systems without libatomic.so (PR #73398)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 30 06:16:01 PST 2023


ldionne wrote:

> 
> So for such environments where the atomics helper functions are unavailable, some tests may succeed and some may fail, depending on what code generation decisions the compiler makes - thus, one can't really mark them `XFAIL`.

We are pretty seriously starting to need compiler-rt on Windows though. This means that atomics on Windows will either work or fail to link depending on how much the compiler decides to inline. And this is also blocking us from refactoring our implementation of `std::complex` to use vastly superior builtins. What would be the path for this to happen?


> Is this patch ready to land? I run through tests on our bots and can confirm it clears the atomic test failures. It would be great to land this patch timely.

Yes, I am merging it now. We were just waiting for the CI to complete over night.


https://github.com/llvm/llvm-project/pull/73398


More information about the libcxx-commits mailing list