[libcxx-commits] [libcxx] [libc++] Reenable codecvt in the dylib. (PR #73679)

[via libcxx-commits]

zeroomega wrote:

@mordante I can confirm e60378bf3e56769134882356d587e7369dfac972 clears the test failure (and build failure as well) on Windows.
As @petrhosek has pointed out, the root cause of the test failure is that libcxx test configration will pass the highest c++ level supported by the clang. In this case, anyone who build libcxx with ToT clang will ran into this test failure issue. I am not sure e60378bf3e56769134882356d587e7369dfac972 is the best fix for this problem (for temporary workaround I am OK with that). If current libcxx cannot be build/test under c++26 on Windows we might want to change the way c++ level was determined by libcxx build configuration and only emit the c++ level supported. Or we should fix the libcxx and its test to perform correctly under c++26 without codecvt on Windows.

As I mentioned in https://github.com/llvm/llvm-project/pull/72496#issuecomment-1832608524 , The build failure is also due to the highest C++ level was picked by the build configuration. We might want to make sure only supported C++ level was used. 

https://github.com/llvm/llvm-project/pull/73679