[libcxx-commits] [libcxx] [libc++] Protect the libc++ implementation from CUDA SDK's `__noinline__` macro (PR #73838)

Dmitri Gribenko via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 29 10:48:59 PST 2023


gribozavr wrote:

> This patch doesn't seem to do that.

That infrastructure was already in place, it was introduced by https://reviews.llvm.org/D147356. The only missing piece was the push/pop bracketing in `__config` itself, which this patch does.

> I think it would be better to fix the CUDA SDK - especially since it's a really simple fix for them.

Yes, we are filing a bug for the CUDA SDK. However the fix will arrive in future SDK versions, the ones currently in use are already conflicting. So ideally libc++ will keep this workaround until those existing SDK versions become obsolete.


https://github.com/llvm/llvm-project/pull/73838


More information about the libcxx-commits mailing list