[libcxx-commits] [libcxx] [libc++] Removes codecvt. (PR #72496)

[via libcxx-commits]

zeroomega wrote:

This patch breaks runtime build for `runtimes-x86_64-pc-windows-msvc` target when using libcxx:

```
FAILED: libcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.obj 
C:\b\s\w\ir\x\w\llvm_build\.\bin\clang-cl.exe --target=x86_64-pc-windows-msvc  /nologo -TP -DUNICODE -D_ALLOW_ITERATOR_DEBUG_LEVEL_MISMATCH -D_ALLOW_MSC_VER_MISMATCH -D_CRTBLD -D_CRT_NONSTDC_NO_DEPRECATE -D_CRT_NONSTDC_NO_WARNINGS -D_CRT_SECURE_NO_DEPRECATE -D_CRT_SECURE_NO_WARNINGS -D_CRT_STDIO_ISO_WIDE_SPECIFIERS -D_GLIBCXX_ASSERTIONS -D_LIBCPP_BUILDING_LIBRARY -D_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS="" -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D_LIBCPP_REMOVE_TRANSITIVE_INCLUDES -D_SCL_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_WARNINGS -D_UNICODE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -IC:/b/s/w/ir/x/w/llvm-llvm-project/libcxx/src -IC:/b/s/w/ir/x/w/llvm_build/include/x86_64-pc-windows-msvc/c++/v1 -IC:/b/s/w/ir/x/w/llvm_build/include/c++/v1 /Zc:inline /Zc:__cplusplus /Oi /bigobj /permissive- /W4 -wd4141 -wd4146 -wd4244 -wd4267 -wd4291 -wd4351 -wd4456 -wd4457 -wd4458 -wd4459 -wd4503 -wd4624 -wd4722 -wd4100 -wd4127 -wd4512 -wd4505 -wd4610 -wd4510 -wd4702 -wd4245 -wd4706 -wd4310 -wd4701 -wd4703 -wd4389 -wd4611 -wd4805 -wd4204 -wd4577 -wd4091 -wd4592 -wd4319 -wd4709 -wd5105 -wd4324 -w14062 -we4238 /Gw -no-canonical-prefixes /Zi /O2 /Ob1  -std:c++latest -MT -UNDEBUG -W4 -Wextra -Wnewline-eof -Wshadow -Wwrite-strings -Wno-unused-parameter -Wno-long-long -Werror=return-type -Wextra-semi -Wundef -Wunused-template -Wformat-nonliteral -Wno-user-defined-literals -Wno-covered-switch-default -Wno-suggest-override -Wno-c++98-compat -Wno-c++98-compat-pedantic -Wno-c++11-compat -Wno-undef -Wno-reserved-id-macro -Wno-gnu-include-next -Wno-gcc-compat -Wno-zero-as-null-pointer-constant -Wno-deprecated-dynamic-exception-spec -Wno-sign-conversion -Wno-old-style-cast -Wno-deprecated -Wno-shift-sign-overflow -Wno-double-promotion -Wno-error -EHsc /showIncludes /Folibcxx/src/CMakeFiles/cxx_static.dir/locale.cpp.obj /Fdlibcxx\src\CMakeFiles\cxx_static.dir\cxx_static.pdb -c -- C:/b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/locale.cpp
C:/b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/locale.cpp(1789,49): error: unknown type name 'codecvt_mode'; did you mean 'codecvt_base'?
 1789 |               unsigned long Maxcode = 0x10FFFF, codecvt_mode mode = codecvt_mode(0))
      |                                                 ^~~~~~~~~~~~
      |                                                 codecvt_base
C:/b/s/w/ir/x/w/llvm_build/include/c++/v1\__locale(901,33): note: 'codecvt_base' declared here
  901 | class _LIBCPP_EXPORTED_FROM_ABI codecvt_base
```

Could you look into this please? If it takes a long time to fix, could you revert the change please?
Builder task: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8763525736105044977/overview

https://github.com/llvm/llvm-project/pull/72496