[libcxx-commits] [libcxx] 2c54513 - [libc++] Fix a few tests that are missing proper suffixes (#73444)

via libcxx-commits libcxx-commits at lists.llvm.org
Sun Nov 26 11:44:27 PST 2023


Author: philnik777
Date: 2023-11-26T20:44:23+01:00
New Revision: 2c545131b09f5ef7b361855ddc609f6687cce184

URL: https://github.com/llvm/llvm-project/commit/2c545131b09f5ef7b361855ddc609f6687cce184
DIFF: https://github.com/llvm/llvm-project/commit/2c545131b09f5ef7b361855ddc609f6687cce184.diff

LOG: [libc++] Fix a few tests that are missing proper suffixes (#73444)

The tests were missing the `.pass.cpp` suffix to be recognized as tests.
As a result, they were never run and some are completely broken.

Added: 
    libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.pass.cpp
    libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.pass.cpp
    libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.pass.cpp
    libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.pass.cpp

Modified: 
    

Removed: 
    libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.cpp
    libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.cpp
    libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp
    libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.cpp


################################################################################
diff  --git a/libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.cpp b/libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.pass.cpp
similarity index 100%
rename from libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.cpp
rename to libcxx/test/std/algorithms/alg.nonmodifying/alg.all_of/pstl.exception_handling.pass.cpp

diff  --git a/libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.cpp b/libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.pass.cpp
similarity index 100%
rename from libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.cpp
rename to libcxx/test/std/experimental/memory/memory.observer.ptr/ctor.copy_move.pass.cpp

diff  --git a/libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp b/libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.pass.cpp
similarity index 52%
rename from libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp
rename to libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.pass.cpp
index 6b45a39d4a81b4d..8855f1dad41bb2e 100644
--- a/libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp
+++ b/libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.pass.cpp
@@ -6,7 +6,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-// UNSUPPORTED: c++03 c++11 c++14 c++17
+// UNSUPPORTED: c++03, c++11, c++14, c++17
 
 // <filesystem>
 
@@ -18,30 +18,30 @@
 #include <cassert>
 #include <filesystem>
 
-#include "test_macros.h"
+#include "test_comparisons.h"
 
 void test() {
   {
-    std::fileystem::file_status f1;
-    std::fileystem::file_status f2;
+    std::filesystem::file_status f1;
+    std::filesystem::file_status f2;
 
     assert(testEquality(f1, f2, true));
   }
   {
-    std::fileystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
-    std::fileystem::file_status f2{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
+    std::filesystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
+    std::filesystem::file_status f2{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
 
     assert(testEquality(f1, f2, true));
   }
   {
-    std::fileystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
-    std::fileystem::file_status f2{std::filesystem::file_type::none, std::filesystem::perms::owner_read};
+    std::filesystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
+    std::filesystem::file_status f2{std::filesystem::file_type::none, std::filesystem::perms::owner_read};
 
     assert(testEquality(f1, f2, false));
   }
   {
-    std::fileystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
-    std::fileystem::file_status f2{std::filesystem::file_type::regular, std::filesystem::perms::owner_write};
+    std::filesystem::file_status f1{std::filesystem::file_type::regular, std::filesystem::perms::owner_read};
+    std::filesystem::file_status f2{std::filesystem::file_type::regular, std::filesystem::perms::owner_write};
 
     assert(testEquality(f1, f2, false));
   }

diff  --git a/libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.cpp b/libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.pass.cpp
similarity index 100%
rename from libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.cpp
rename to libcxx/test/std/iterators/predef.iterators/counted.iterator/increment.pass.cpp


        


More information about the libcxx-commits mailing list