[libcxx-commits] [libcxx] [libc++][test] Cleanup typos and unnecessary semicolons (PR #73435)
via libcxx-commits
libcxx-commits at lists.llvm.org
Sun Nov 26 02:39:32 PST 2023
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-libcxx
Author: Stephan T. Lavavej (StephanTLavavej)
<details>
<summary>Changes</summary>
I've structured this into a series of commits for even easier reviewing, if that helps. I could easily split this up into separate PRs if desired, but as this is low-risk with simple edits, I thought one PR would be easiest.
* Drop unnecessary semicolons after function definitions.
* Cleanup comment typos.
* Cleanup `static_assert` typos.
* Cleanup test code typos.
+ There should be no functional changes, assuming I've changed all occurrences.
* Fix massive test code typos in `libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp` which repeatedly said `std::fileystem`.
+ This didn't appear to be intentional, and I'm not sure how this was compiling. I suspect that something prevented this test from running at all. Perhaps this is related to how its `UNSUPPORTED` comment weirdly lacks commas: https://github.com/llvm/llvm-project/blob/9ba74c2ee044381544c8e1e736c4c85a1a9d56bf/libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp#L9 Unlike other tests where this is comma-separated: https://github.com/llvm/llvm-project/blob/9ba74c2ee044381544c8e1e736c4c85a1a9d56bf/libcxx/test/std/input.output/syncstream/osyncstream/assign.pass.cpp#L9
---
Patch is 91.40 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/73435.diff
94 Files Affected:
- (modified) libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp (+2-2)
- (modified) libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp (+1-1)
- (modified) libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp (+2-2)
- (modified) libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp (+1-1)
- (modified) libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp (+2-2)
- (modified) libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp (+2-2)
- (modified) libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp (+1-1)
- (modified) libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp (+10-10)
- (modified) libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp (+9-9)
- (modified) libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp (+1-1)
- (modified) libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp (+1-1)
- (modified) libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp (+1-1)
- (modified) libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp (+1-1)
- (modified) libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/sequences/deque/deque.modifiers/push_back_exception_safety.pass.cpp (+4-4)
- (modified) libcxx/test/std/containers/sequences/deque/deque.modifiers/push_front_exception_safety.pass.cpp (+4-4)
- (modified) libcxx/test/std/containers/sequences/forwardlist/forwardlist.modifiers/push_front_exception_safety.pass.cpp (+3-3)
- (modified) libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/remove_if.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/sequences/forwardlist/forwardlist.ops/unique_pred.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/sequences/list/list.modifiers/push_back_exception_safety.pass.cpp (+3-3)
- (modified) libcxx/test/std/containers/sequences/list/list.modifiers/push_front_exception_safety.pass.cpp (+3-3)
- (modified) libcxx/test/std/containers/sequences/list/list.ops/remove_if.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/sequences/list/list.ops/unique_pred.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/ConvertibleToIntegral.h (+2-2)
- (modified) libcxx/test/std/containers/views/mdspan/CustomTestLayouts.h (+4-4)
- (modified) libcxx/test/std/containers/views/mdspan/extents/CtorTestCombinations.h (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/extents/ctad.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/extents/ctor_default.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/extents/ctor_from_array.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/extents/ctor_from_span.pass.cpp (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/mdspan/CustomTestAccessors.h (+1-1)
- (modified) libcxx/test/std/containers/views/mdspan/mdspan/types.pass.cpp (+1-1)
- (modified) libcxx/test/std/experimental/simd/simd.class/simd_ctor_default.pass.cpp (+1-1)
- (modified) libcxx/test/std/experimental/simd/simd.mask.class/simd_mask_ctor_default.pass.cpp (+1-1)
- (modified) libcxx/test/std/input.output/filesystems/class.file_status/file_status.status.eq.ops.cpp (+8-8)
- (modified) libcxx/test/std/input.output/syncstream/syncbuf/sputc.pass.cpp (+3-3)
- (modified) libcxx/test/std/input.output/syncstream/syncbuf/sputn.pass.cpp (+3-3)
- (modified) libcxx/test/std/input.output/syncstream/syncbuf/syncstream.syncbuf.assign/assign.pass.cpp (+1-1)
- (modified) libcxx/test/std/numerics/numarray/class.gslice/gslice.cons/default.pass.cpp (+1-1)
- (modified) libcxx/test/std/numerics/numarray/class.gslice/gslice.cons/start_size_stride.pass.cpp (+1-1)
- (modified) libcxx/test/std/ranges/range.adaptors/range.drop/dangling.cache.pass.cpp (+2-2)
- (modified) libcxx/test/std/ranges/range.adaptors/range.join.view/sentinel/ctor.other.pass.cpp (+6-6)
- (modified) libcxx/test/std/ranges/range.adaptors/range.reverse/begin.pass.cpp (+1-1)
- (modified) libcxx/test/std/ranges/range.adaptors/range.zip/end.pass.cpp (+4-4)
- (modified) libcxx/test/std/ranges/range.adaptors/range.zip/iterator/iter_move.pass.cpp (+1-1)
- (modified) libcxx/test/std/ranges/range.adaptors/range.zip/iterator/iter_swap.pass.cpp (+1-1)
- (modified) libcxx/test/std/ranges/range.adaptors/range.zip/sentinel/minus.pass.cpp (+3-3)
- (modified) libcxx/test/std/ranges/range.adaptors/range.zip/types.h (+2-2)
- (modified) libcxx/test/std/ranges/range.factories/range.repeat.view/views_repeat.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.const/re.matchflag/match_flag_type.pass.cpp (+1-1)
- (modified) libcxx/test/std/re/re.const/re.synopt/syntax_option_type.pass.cpp (+1-1)
- (modified) libcxx/test/std/strings/string.view/string.view.comparison/common_type_specialization.pass.cpp (+1-1)
- (modified) libcxx/test/std/thread/futures/futures.async/async.pass.cpp (+2-2)
- (modified) libcxx/test/std/thread/thread.mutex/thread.lock/thread.lock.shared/thread.lock.shared.cons/mutex_duration.pass.cpp (+2-2)
- (modified) libcxx/test/std/time/time.syn/formatter.file_time.pass.cpp (+1-1)
- (modified) libcxx/test/std/time/time.syn/formatter.sys_time.pass.cpp (+1-1)
- (modified) libcxx/test/std/time/time.zone/time.zone.db/time.zone.db.list/erase_after.compile.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/expected/expected.expected/assign/assign.U.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/expected/expected.expected/assign/emplace.intializer_list.pass.cpp (+7-7)
- (modified) libcxx/test/std/utilities/expected/expected.expected/swap/free.swap.pass.cpp (+5-5)
- (modified) libcxx/test/std/utilities/expected/expected.expected/swap/member.swap.pass.cpp (+5-5)
- (modified) libcxx/test/std/utilities/expected/expected.void/swap/free.swap.pass.cpp (+4-4)
- (modified) libcxx/test/std/utilities/expected/expected.void/swap/member.swap.pass.cpp (+4-4)
- (modified) libcxx/test/std/utilities/expected/types.h (+1-1)
- (modified) libcxx/test/std/utilities/format/format.formattable/concept.formattable.compile.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/format/format.formatter/format.context/format.context/ctor.pass.cpp (+2-2)
- (modified) libcxx/test/std/utilities/format/format.formatter/format.context/format.context/locale.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/format/format.functions/escaped_output.ascii.pass.cpp (+2-2)
- (modified) libcxx/test/std/utilities/format/format.functions/escaped_output.unicode.pass.cpp (+2-2)
- (modified) libcxx/test/std/utilities/format/format.functions/format_tests.h (+3-3)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.enab/enable_shared_from_this.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.const/pointer_deleter_allocator.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/allocate_shared.lwg2070.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.create/make_shared.private.compile.fail.cpp (+1-1)
- (modified) libcxx/test/std/utilities/memory/util.smartptr/util.smartptr.shared/util.smartptr.shared.obs/op_bool.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/smartptr/unique.ptr/unique.ptr.class/unique.ptr.asgn/move.pass.cpp (+1-1)
- (modified) libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_UTypes.pass.cpp (+2-2)
- (modified) libcxx/test/std/utilities/tuple/tuple.tuple/tuple.cnstr/alloc_const_Types.verify.cpp (+1-1)
- (modified) libcxx/test/std/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/tracking_mem_res.h (+4-4)
- (modified) libcxx/test/std/utilities/utility/pairs/pairs.pair/assign_rv_pair_U_V.pass.cpp (+2-2)
- (modified) libcxx/test/support/assert_macros.h (+1-1)
- (modified) libcxx/test/support/boolean_testable.h (+1-1)
- (modified) libcxx/test/support/concat_macros.h (+1-1)
- (modified) libcxx/test/support/copy_move_types.h (+2-2)
- (modified) libcxx/test/support/iterator_traits_cpp17_iterators.h (+2-2)
- (modified) libcxx/test/support/test_container_comparisons.h (+1-1)
- (modified) libcxx/test/support/test_iterators.h (+6-6)
``````````diff
diff --git a/libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp b/libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp
index 15f99a56ad1c364..0c5ae84d97700b0 100644
--- a/libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp
+++ b/libcxx/test/libcxx/algorithms/alg.modifying.operations/copy_move_nontrivial.pass.cpp
@@ -302,10 +302,10 @@ constexpr bool test() {
// Copying from `bool` to `char` will invoke the optimization, so only check one direction.
test_copy_and_move<char, bool>();
- // Copying between different structs with the same represenation (there is no way to guarantee the representation is
+ // Copying between different structs with the same representation (there is no way to guarantee the representation is
// the same).
test_copy_and_move<S1, S2>();
- // Copying between different unions with the same represenation.
+ // Copying between different unions with the same representation.
test_copy_and_move<U1, U2>();
// Copying from a regular pointer to a void pointer (these are not considered trivially copyable).
diff --git a/libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp b/libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp
index 25aed98fe136683..09258f7c9eb5635 100644
--- a/libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp
+++ b/libcxx/test/libcxx/algorithms/pstl.robust_against_customization_points_not_working.pass.cpp
@@ -9,7 +9,7 @@
// UNSUPPORTED: c++03, c++11, c++14
// UNSUPPORTED: libcpp-has-no-incomplete-pstl
-// Having a customization point outside the module doesn't work, so this test is inherintly module-hostile.
+// Having a customization point outside the module doesn't work, so this test is inherently module-hostile.
// UNSUPPORTED: clang-modules-build
// Make sure that the customization points get called properly when overloaded
diff --git a/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp b/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp
index 24b5ff903c10b91..8bfc865f2b5f5b7 100644
--- a/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp
+++ b/libcxx/test/libcxx/containers/views/mdspan/layout_stride/assert.conversion.pass.cpp
@@ -101,7 +101,7 @@ int main(int, char**) {
([=] { std::layout_stride::template mapping<std::extents<signed char, D, 10>> m(arg); }()),
"layout_stride::mapping converting ctor: other.required_span_size() must be representable as index_type.");
}
- // base offset must be 0 (i.e. mapping(0,...,0)==0) for a strided layout with positiv strides
+ // base offset must be 0 (i.e. mapping(0,...,0)==0) for a strided layout with positive strides
{
always_convertible_layout::mapping<std::dextents<int, 2>> offset_map(std::dextents<int, 2>{10, 10}, 3);
TEST_LIBCPP_ASSERT_FAILURE(
diff --git a/libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp
index a1400336cefde2e..16ca0b68ceb0aa0 100644
--- a/libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/bit.nodiscard_extensions.compile.pass.cpp
@@ -11,7 +11,7 @@
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_NODISCARD_EXT
// Check that <bit> functions aren't marked [[nodiscard]] when
-// _LIBCPP_DISBALE_NODISCARD_EXT is defined
+// _LIBCPP_DISABLE_NODISCARD_EXT is defined
#include <bit>
diff --git a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
index 95b18eba26e7750..1f30af06fedd879 100644
--- a/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/chrono.nodiscard_extensions.compile.pass.cpp
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// Check that format functions aren't marked [[nodiscard]] when
-// _LIBCPP_DISBALE_NODISCARD_EXT is defined
+// _LIBCPP_DISABLE_NODISCARD_EXT is defined
// UNSUPPORTED: c++03, c++11, c++14, c++17
// UNSUPPORTED: no-filesystem, no-localization, no-tzdb
diff --git a/libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp
index d443687bac338d6..b4f2415872ca87c 100644
--- a/libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/format.nodiscard_extensions.compile.pass.cpp
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// Check that format functions aren't marked [[nodiscard]] when
-// _LIBCPP_DISBALE_NODISCARD_EXT is defined
+// _LIBCPP_DISABLE_NODISCARD_EXT is defined
// TODO FMT This test should not require std::to_chars(floating-point)
// XFAIL: availability-fp_to_chars-missing
diff --git a/libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp
index 546433df5a4d608..01e228c09cc3bbb 100644
--- a/libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/pstl.nodiscard_extensions.compile.pass.cpp
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// Check that PSTL algorithms aren't marked [[nodiscard]] when
-// _LIBCPP_DISBALE_NODISCARD_EXT is defined
+// _LIBCPP_DISABLE_NODISCARD_EXT is defined
// ADDITIONAL_COMPILE_FLAGS: -D_LIBCPP_DISABLE_NODISCARD_EXT
diff --git a/libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp b/libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp
index 5ec227311472e86..7e2d64b8c9b6186 100644
--- a/libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp
+++ b/libcxx/test/libcxx/diagnostics/ranges.nodiscard_extensions.compile.pass.cpp
@@ -7,7 +7,7 @@
//===----------------------------------------------------------------------===//
// Check that ranges algorithms aren't marked [[nodiscard]] when
-// _LIBCPP_DISBALE_NODISCARD_EXT is defined
+// _LIBCPP_DISABLE_NODISCARD_EXT is defined
// UNSUPPORTED: c++03, c++11, c++14, c++17
diff --git a/libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp b/libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
index 728762cf0faab31..be9909c91d77b92 100644
--- a/libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
+++ b/libcxx/test/libcxx/experimental/memory/memory.polymorphic.allocator.class/memory.polymorphic.allocator.mem/construct_piecewise_pair.pass.cpp
@@ -21,7 +21,7 @@
// void polymorphic_allocator<T>::construct(pair<T1, T2>*, piecewise_construct_t
// tuple<Args1...> x, tuple<Args2...>)
-// The stardard specifiers a tranformation to uses-allocator construction as
+// The standard specifies a transformation to uses-allocator construction as
// follows:
// - If uses_allocator_v<T1,memory_resource*> is false and
// is_constructible_v<T,Args1...> is true, then xprime is x.
@@ -36,7 +36,7 @@
//
// The use of "xprime = tuple_cat(..., std::move(x), ...)" causes all of the
// objects in 'x' to be copied into 'xprime'. If 'x' contains any types which
-// are stored by value this causes an unessary copy to occur. To prevent this
+// are stored by value this causes an unnecessary copy to occur. To prevent this
// libc++ changes this call into
// "xprime = forward_as_tuple(..., std::get<Idx>(std::move(x))..., ...)".
// 'xprime' contains references to the values in 'x' instead of copying them.
diff --git a/libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp b/libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp
index 58b9db45d37a2a4..d37f1a4bfac519b 100644
--- a/libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp
+++ b/libcxx/test/libcxx/utilities/meta/stress_tests/stress_test_variant_overloads_impl.sh.cpp
@@ -99,7 +99,7 @@ using Overloads = Overload<Types...>;
namespace variant_impl {
template <class ...Types>
using Overloads = std::__variant_detail::_MakeOverloads<Types...>;
-} // naamespace variant_impl
+} // namespace variant_impl
#ifndef TEST_NS
#error TEST_NS must be defined
diff --git a/libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp b/libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp
index 916f9c31d4e9025..55a51c9fc26e848 100644
--- a/libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp
+++ b/libcxx/test/libcxx/utilities/utility/mem.res/mem.poly.allocator.class/mem.poly.allocator.mem/construct_piecewise_pair.pass.cpp
@@ -21,7 +21,7 @@
// void polymorphic_allocator<T>::construct(pair<T1, T2>*, piecewise_construct_t
// tuple<Args1...> x, tuple<Args2...>)
-// The stardard specifiers a tranformation to uses-allocator construction as
+// The standard specifies a transformation to uses-allocator construction as
// follows:
// - If uses_allocator_v<T1,memory_resource*> is false and
// is_constructible_v<T,Args1...> is true, then xprime is x.
@@ -36,7 +36,7 @@
//
// The use of "xprime = tuple_cat(..., std::move(x), ...)" causes all of the
// objects in 'x' to be copied into 'xprime'. If 'x' contains any types which
-// are stored by value this causes an unessary copy to occur. To prevent this
+// are stored by value this causes an unnecessary copy to occur. To prevent this
// libc++ changes this call into
// "xprime = forward_as_tuple(..., std::get<Idx>(std::move(x))..., ...)".
// 'xprime' contains references to the values in 'x' instead of copying them.
diff --git a/libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp b/libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp
index 319259913cc3293..96387b2adfb7787 100644
--- a/libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.modifying.operations/alg.remove/ranges.remove.pass.cpp
@@ -35,7 +35,7 @@ static_assert(!HasRemoveIt<PermutableNotForwardIterator>);
static_assert(!HasRemoveIt<PermutableNotSwappable>);
static_assert(!HasRemoveIt<int*, SentinelForNotSemiregular>);
static_assert(!HasRemoveIt<int*, SentinelForNotWeaklyEqualityComparableWith>);
-static_assert(!HasRemoveIt<int**>); // not indirect_binary_prediacte
+static_assert(!HasRemoveIt<int**>); // not indirect_binary_predicate
template <class Range>
concept HasRemoveR = requires(Range range) { std::ranges::remove(range, 0); };
@@ -45,7 +45,7 @@ static_assert(!HasRemoveR<PermutableRangeNotForwardIterator>);
static_assert(!HasRemoveR<PermutableRangeNotSwappable>);
static_assert(!HasRemoveR<SentinelForNotSemiregular>);
static_assert(!HasRemoveR<SentinelForNotWeaklyEqualityComparableWith>);
-static_assert(!HasRemoveR<UncheckedRange<int**>>); // not indirect_binary_prediacte
+static_assert(!HasRemoveR<UncheckedRange<int**>>); // not indirect_binary_predicate
template <int N, int M>
struct Data {
diff --git a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp
index 94209020e35e0ed..b604263e525d272 100644
--- a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.iterator.pass.cpp
@@ -19,7 +19,7 @@
// ranges::transform(I1 first1, S1 last1, I2 first2, S2 last2, O result,
// F binary_op, Proj1 proj1 = {}, Proj2 proj2 = {});
-// The range overloads are tested in ranges.tranform.binary.range.pass.cpp.
+// The range overloads are tested in ranges.transform.binary.range.pass.cpp.
#include <algorithm>
#include <array>
diff --git a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp
index bebe4561bd579c6..08ca8aa3fd9ee24 100644
--- a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.binary.range.pass.cpp
@@ -18,7 +18,7 @@
// ranges::transform(R1&& r1, R2&& r2, O result,
// F binary_op, Proj1 proj1 = {}, Proj2 proj2 = {});
-// The iterator overloads are tested in ranges.tranform.binary.iterator.pass.cpp.
+// The iterator overloads are tested in ranges.transform.binary.iterator.pass.cpp.
#include <algorithm>
#include <array>
@@ -34,15 +34,15 @@ struct BinaryFunc {
};
template <class Range>
-concept HasTranformR = requires(Range r, int* out) { std::ranges::transform(r, r, out, BinaryFunc{}); };
-
-static_assert(HasTranformR<std::array<int, 1>>);
-static_assert(!HasTranformR<int>);
-static_assert(!HasTranformR<InputRangeNotDerivedFrom>);
-static_assert(!HasTranformR<InputRangeNotIndirectlyReadable>);
-static_assert(!HasTranformR<InputRangeNotInputOrOutputIterator>);
-static_assert(!HasTranformR<InputRangeNotSentinelSemiregular>);
-static_assert(!HasTranformR<InputRangeNotSentinelEqualityComparableWith>);
+concept HasTransformR = requires(Range r, int* out) { std::ranges::transform(r, r, out, BinaryFunc{}); };
+
+static_assert(HasTransformR<std::array<int, 1>>);
+static_assert(!HasTransformR<int>);
+static_assert(!HasTransformR<InputRangeNotDerivedFrom>);
+static_assert(!HasTransformR<InputRangeNotIndirectlyReadable>);
+static_assert(!HasTransformR<InputRangeNotInputOrOutputIterator>);
+static_assert(!HasTransformR<InputRangeNotSentinelSemiregular>);
+static_assert(!HasTransformR<InputRangeNotSentinelEqualityComparableWith>);
template <class It>
concept HasTransformOut = requires(int* it, int* sent, It out, std::array<int, 2> range) {
diff --git a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp
index b83f9cc4f060f95..eeacf83664cfeef 100644
--- a/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.modifying.operations/alg.transform/ranges.transform.unary.pass.cpp
@@ -31,15 +31,15 @@
#include "almost_satisfies_types.h"
template <class Range>
-concept HasTranformR = requires(Range r, int* out) { std::ranges::transform(r, out, std::identity{}); };
-
-static_assert(HasTranformR<std::array<int, 1>>);
-static_assert(!HasTranformR<int>);
-static_assert(!HasTranformR<InputRangeNotDerivedFrom>);
-static_assert(!HasTranformR<InputRangeNotIndirectlyReadable>);
-static_assert(!HasTranformR<InputRangeNotInputOrOutputIterator>);
-static_assert(!HasTranformR<InputRangeNotSentinelSemiregular>);
-static_assert(!HasTranformR<InputRangeNotSentinelEqualityComparableWith>);
+concept HasTransformR = requires(Range r, int* out) { std::ranges::transform(r, out, std::identity{}); };
+
+static_assert(HasTransformR<std::array<int, 1>>);
+static_assert(!HasTransformR<int>);
+static_assert(!HasTransformR<InputRangeNotDerivedFrom>);
+static_assert(!HasTransformR<InputRangeNotIndirectlyReadable>);
+static_assert(!HasTransformR<InputRangeNotInputOrOutputIterator>);
+static_assert(!HasTransformR<InputRangeNotSentinelSemiregular>);
+static_assert(!HasTransformR<InputRangeNotSentinelEqualityComparableWith>);
template <class It, class Sent = It>
concept HasTransformIt =
diff --git a/libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp b/libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
index faf597c970ff23a..e28cbe2a08de4ab 100644
--- a/libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.nonmodifying/alg.equal/equal.pass.cpp
@@ -18,7 +18,7 @@
// constexpr bool // constexpr after c++17
// equal(Iter1 first1, Iter1 last1, Iter2 first2, Iter2 last2);
-// We test the cartesian product, so we somethimes compare differently signed types
+// We test the cartesian product, so we sometimes compare differently signed types
// ADDITIONAL_COMPILE_FLAGS: -Wno-sign-compare
#include <algorithm>
diff --git a/libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp b/libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp
index 9641411ef2b2e30..913819979ca1cda 100644
--- a/libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.nonmodifying/alg.foreach/ranges.for_each_n.pass.cpp
@@ -57,7 +57,7 @@ constexpr void test_iterator() {
assert(i == 4);
}
- { // check that an emptry range works
+ { // check that an empty range works
int a[] = {};
std::ranges::for_each_n(Iter(a), 0, [](auto&) { assert(false); });
}
diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp
index 9795d1eb2b85b4a..72b58f5534140bf 100644
--- a/libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.sorting/alg.partitions/ranges.is_partitioned.pass.cpp
@@ -87,7 +87,7 @@ constexpr void test_iterators() {
}
}
- { // check that it's partitoned if the predicate is true for all elements
+ { // check that it's partitioned if the predicate is true for all elements
{
int a[] = {1, 2, 3, 4};
auto ret = std::ranges::is_partitioned(Iter(a), Sent(Iter(a + 4)), [](int) { return true; });
diff --git a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
index ed26c5b861f5a25..554bd8982ab3331 100644
--- a/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
+++ b/libcxx/test/std/algorithms/alg.sorting/alg.sort/sort/sort.pass.cpp
@@ -190,7 +190,7 @@ test_pointer_sort()
// test_adversarial_quicksort generates a vector with values arranged in such a
// way that they would invoke O(N^2) behavior on any quick sort implementation
-// that satisifies certain conditions. Details are available in the following
+// that satisfies certain conditions. Details are available in the following
// paper:
// "A Killer Adversary for Quicksort", M. D. McIlroy, Software-Practice &
// Experience Volume 29 Issue 4 April 10, 1999 pp 341-344.
diff --git a/libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp b/libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp
index 7151c1c8bb31d40..6d798b264678ef9 100644
--- a/libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp
+++ b/libcxx/test/std/concepts/concepts.object/semiregular.compile.pass.cpp
@@ -107,7 +107,7 @@ static_assert(!std::semiregular<has_rvalue_reference_member>);
static_assert(!std::semiregular<has_function_ref_member>);
static_assert(!std::semiregular<deleted_assignment_from_const_rvalue>);
-// Not default_initialzable
+// Not default_initializable
static_assert(!std::semiregular<std::runtime_error>);
static_assert(
!std::semiregular<std::tuple<std::runtime_error, std::overflow_error> >);
diff --git a/libcxx/test/std/containers/sequences/deque/deque.modifiers/push_back_exception_safety.pass.cpp b/libcxx/test/std/containers/sequences/deq...
[truncated]
``````````
</details>
https://github.com/llvm/llvm-project/pull/73435
More information about the libcxx-commits
mailing list