[libcxx-commits] [libcxx] [libcxxabi] [libc++] Remove dependence on <ciso646> (PR #73271)

[Michael Kenzel via libcxx-commits]

================
@@ -12,15 +12,15 @@
 
 // Attempt to get STL specific macros like _LIBCPP_VERSION using the most
 // minimal header possible. If we're testing libc++, we should use `<__config>`.
-// If <__config> isn't available, fall back to <ciso646>.
+// If <__config> isn't available, fall back to <version>.
 #ifdef __has_include
 # if __has_include("<__config>")
 #   include <__config>
 #   define TEST_IMP_INCLUDED_HEADER
 # endif
 #endif
 #ifndef TEST_IMP_INCLUDED_HEADER
-#include <ciso646>
+#  include <version>
----------------
michael-kenzel wrote:

I guess this comes down to the question of whether the test suite really can and should be fully independent of the implementation it's supposed to test. I certainly don't have any insight into where the libc++ test suite stands on that. If the test suite really only tests the library interface defined in the C++ specification, then I do see the point of making it work with any hypothetical implementation. That little added complexity would probably be justified then. I'll be happy to add that to the PR, I'll just wait for a clear decision on whether it should be added.

https://github.com/llvm/llvm-project/pull/73271