[libcxx-commits] [libcxx] [libc++] Use __is_pointer_in_range for char_traits checks (PR #72643)

[via libcxx-commits]

bgra8 wrote:

Not at my desk now. The UB is documented in the implementation
of  __is_pointer_in_range() func.

On Fri, Nov 24, 2023, 8:37 PM philnik777 ***@***.***> wrote:

> heads-up @philnik777 <https://github.com/philnik777>: we have about 30
> test failures that have all bisected to this revision.
>
> I noticed std::__is_pointer_in_range() has a deliberate UB. Replacing
> that with the std::reinterpret_cast<const char*> implementation and then
> rebuilding the compiler and libc++ makes all tests pass.
>
> Should we revert this?
>
> I'd like to understand the issue first. What deliberate UB are you talking
> about?
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/llvm/llvm-project/pull/72643#issuecomment-1826034524>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AHWNISGIL5X6PTCJTKY5GKTYGDZQZAVCNFSM6AAAAAA7PWYLJGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRWGAZTINJSGQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>


https://github.com/llvm/llvm-project/pull/72643